components/autofill/content/renderer/password_form_conversion_utils.cc - Issue 1220653002: Fix some case-insensitive cases for StartsWith

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc

index 3d7d20dca76b972fbef6a5f07de1371d28b77b08..22be42e8da278c8374a5d11229bcd879e187df4b 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc

@@ -6,6 +6,7 @@

#include <vector>

+#include "base/i18n/case_conversion.h"

#include "base/lazy_instance.h"

#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram_macros.h"

@@ -380,7 +381,10 @@ void GetPasswordForm(

nonscript_modified_values->find(username_element);

if (username_iterator != nonscript_modified_values->end()) {

base::string16 typed_username_value = username_iterator->second;

- if (!base::StartsWith(username_value, typed_username_value, false)) {

+ if (!base::StartsWith(

+ base::i18n::ToLower(username_value),

+ base::i18n::ToLower(typed_username_value),

+ base::CompareCase::SENSITIVE)) {

// We check that |username_value| was not obtained by autofilling

// |typed_username_value|. In case when it was, |typed_username_value|

// is incomplete, so we should leave autofilled value.