Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: components/browser_watcher/exit_code_watcher_win_unittest.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bookmarks/browser/bookmark_utils.cc ('k') | components/omnibox/answers_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/exit_code_watcher_win_unittest.cc
diff --git a/components/browser_watcher/exit_code_watcher_win_unittest.cc b/components/browser_watcher/exit_code_watcher_win_unittest.cc
index 10ba2fd4128476359098619c721673bcf740ae28..118cf770a3d3b7190b0b8f807aafaef1ddb71a80 100644
--- a/components/browser_watcher/exit_code_watcher_win_unittest.cc
+++ b/components/browser_watcher/exit_code_watcher_win_unittest.cc
@@ -98,8 +98,10 @@ class ExitCodeWatcherTest : public testing::Test {
KEY_QUERY_VALUE);
// The value name should encode the process id at the start.
- EXPECT_TRUE(base::StartsWith(it.Name(), base::StringPrintf(L"%d-", proc_id),
- false));
+ EXPECT_TRUE(base::StartsWith(
+ it.Name(),
+ base::StringPrintf(L"%d-", proc_id),
+ base::CompareCase::SENSITIVE));
DWORD value = 0;
ASSERT_EQ(ERROR_SUCCESS, key.ReadValueDW(it.Name(), &value));
ASSERT_EQ(exit_code, value);
« no previous file with comments | « components/bookmarks/browser/bookmark_utils.cc ('k') | components/omnibox/answers_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698