components/search_engines/template_url_service_util_unittest.cc - Issue 1220653002: Fix some case-insensitive cases for StartsWith

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_service_util_unittest.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url_service_util_unittest.cc

diff --git a/components/search_engines/template_url_service_util_unittest.cc b/components/search_engines/template_url_service_util_unittest.cc

index f29398344d4a7d5c49bee8f4d1f9b1d93be171c3..9f944c5c32b414cebae071e1ed51f076503177b1 100644

--- a/components/search_engines/template_url_service_util_unittest.cc

+++ b/components/search_engines/template_url_service_util_unittest.cc

@@ -96,6 +96,7 @@ TEST(TemplateURLServiceUtilTest, RemoveDuplicatePrepopulateIDs) {

for (TemplateURLService::TemplateURLVector::const_iterator itr =

local_turls.begin(); itr != local_turls.end(); ++itr) {

EXPECT_TRUE(base::StartsWith((*itr)->keyword(),

- base::ASCIIToUTF16("winner"), true));

+ base::ASCIIToUTF16("winner"),

+ base::CompareCase::SENSITIVE));

}