net/base/net_util_icu.cc - Issue 1220653002: Fix some case-insensitive cases for StartsWith

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_util_icu.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/net_util_icu.cc

diff --git a/net/base/net_util_icu.cc b/net/base/net_util_icu.cc

index 0c2644b03976d4c17a1dc29011c18ff48289d3bb..0ece5eac227c5a965f2608d225ec8a56b6c7b4ba 100644

--- a/net/base/net_util_icu.cc

+++ b/net/base/net_util_icu.cc

@@ -794,7 +794,8 @@ base::string16 FormatUrlWithAdjustments(

// If we need to strip out http do it after the fact.

if (omit_http &&

- base::StartsWith(url_string, base::ASCIIToUTF16(kHTTP), true)) {

+ base::StartsWith(url_string, base::ASCIIToUTF16(kHTTP),

+ base::CompareCase::SENSITIVE)) {

const size_t kHTTPSize = arraysize(kHTTP) - 1;

url_string = url_string.substr(kHTTPSize);

// Because offsets in the |adjustments| are already calculated with respect

« no previous file with comments | « net/base/net_util.cc ('k') | net/ftp/ftp_directory_listing_parser_netware.cc » ('j') | no next file with comments »