Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: components/bookmarks/browser/bookmark_utils.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_utils.cc
diff --git a/components/bookmarks/browser/bookmark_utils.cc b/components/bookmarks/browser/bookmark_utils.cc
index e9f32d4b3ee86b05a24d13ac24d525bca352d1d6..13f999ae0d266115ffd9c50b62dafaaaffc5586b 100644
--- a/components/bookmarks/browser/bookmark_utils.cc
+++ b/components/bookmarks/browser/bookmark_utils.cc
@@ -259,10 +259,13 @@ void MakeTitleUnique(const BookmarkModel* model,
const GURL& url,
base::string16* title) {
base::hash_set<base::string16> titles;
+ base::string16 original_title_lower = base::i18n::ToLower(*title);
for (int i = 0; i < parent->child_count(); i++) {
const BookmarkNode* node = parent->GetChild(i);
if (node->is_url() && (url == node->url()) &&
- base::StartsWith(node->GetTitle(), *title, false)) {
+ base::StartsWith(base::i18n::ToLower(node->GetTitle()),
+ original_title_lower,
+ base::CompareCase::SENSITIVE)) {
titles.insert(node->GetTitle());
}
}

Powered by Google App Engine
This is Rietveld 408576698