net/base/net_util.cc - Issue 1220653002: Fix some case-insensitive cases for StartsWith

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_util.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/net_util.cc

diff --git a/net/base/net_util.cc b/net/base/net_util.cc

index c59b3cd7ff4e91e1468ae5ca13a3c8110cc07882..73fa5f287d2e909a262445e55da134126d5ac353 100644

--- a/net/base/net_util.cc

+++ b/net/base/net_util.cc

@@ -279,7 +279,8 @@ bool IsCanonicalizedHostCompliant(const std::string& host) {

base::string16 StripWWW(const base::string16& text) {

const base::string16 www(base::ASCIIToUTF16("www."));

- return base::StartsWith(text, www, true) ? text.substr(www.length()) : text;

+ return base::StartsWith(text, www, base::CompareCase::SENSITIVE)

+ ? text.substr(www.length()) : text;

}

base::string16 StripWWWFromHost(const GURL& url) {

« no previous file with comments | « extensions/common/extension_urls.cc ('k') | net/base/net_util_icu.cc » ('j') | no next file with comments »