Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4656)

Unified Diff: chrome/installer/util/shell_util_unittest.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util_unittest.cc
diff --git a/chrome/installer/util/shell_util_unittest.cc b/chrome/installer/util/shell_util_unittest.cc
index 68fc57d05bd365f393d93ea2cdd52b1b3b576e15..3b97dd0d06106d40d969b50105c140f6ba231781 100644
--- a/chrome/installer/util/shell_util_unittest.cc
+++ b/chrome/installer/util/shell_util_unittest.cc
@@ -979,7 +979,7 @@ TEST(ShellUtilTest, BuildAppModelIdLongEverything) {
TEST(ShellUtilTest, GetUserSpecificRegistrySuffix) {
base::string16 suffix;
ASSERT_TRUE(ShellUtil::GetUserSpecificRegistrySuffix(&suffix));
- ASSERT_TRUE(base::StartsWith(suffix, L".", true));
+ ASSERT_TRUE(base::StartsWith(suffix, L".", base::CompareCase::SENSITIVE));
ASSERT_EQ(27, suffix.length());
ASSERT_TRUE(base::ContainsOnlyChars(suffix.substr(1),
L"ABCDEFGHIJKLMNOPQRSTUVWXYZ234567"));
@@ -988,7 +988,7 @@ TEST(ShellUtilTest, GetUserSpecificRegistrySuffix) {
TEST(ShellUtilTest, GetOldUserSpecificRegistrySuffix) {
base::string16 suffix;
ASSERT_TRUE(ShellUtil::GetOldUserSpecificRegistrySuffix(&suffix));
- ASSERT_TRUE(base::StartsWith(suffix, L".", true));
+ ASSERT_TRUE(base::StartsWith(suffix, L".", base::CompareCase::SENSITIVE));
wchar_t user_name[256];
DWORD size = arraysize(user_name);
« no previous file with comments | « chrome/installer/util/install_util.cc ('k') | components/autofill/content/browser/wallet/wallet_service_url.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698