Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: content/browser/loader/resource_dispatcher_host_browsertest.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/storage_monitor/portable_device_watcher_win.cc ('k') | content/common/plugin_list_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_dispatcher_host_browsertest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_browsertest.cc b/content/browser/loader/resource_dispatcher_host_browsertest.cc
index 0fa2733e63285053875a5bc330852b99bf48bf68..bd320f69989eca413d7ab4d39f7d62fd0e8a33f3 100644
--- a/content/browser/loader/resource_dispatcher_host_browsertest.cc
+++ b/content/browser/loader/resource_dispatcher_host_browsertest.cc
@@ -103,7 +103,8 @@ IN_PROC_BROWSER_TEST_F(ResourceDispatcherHostBrowserTest, DynamicTitle1) {
GURL url(embedded_test_server()->GetURL("/dynamic1.html"));
base::string16 title;
ASSERT_TRUE(GetPopupTitle(url, &title));
- EXPECT_TRUE(base::StartsWith(title, ASCIIToUTF16("My Popup Title"), true))
+ EXPECT_TRUE(base::StartsWith(title, ASCIIToUTF16("My Popup Title"),
+ base::CompareCase::SENSITIVE))
<< "Actual title: " << title;
}
@@ -115,7 +116,8 @@ IN_PROC_BROWSER_TEST_F(ResourceDispatcherHostBrowserTest, DynamicTitle2) {
GURL url(embedded_test_server()->GetURL("/dynamic2.html"));
base::string16 title;
ASSERT_TRUE(GetPopupTitle(url, &title));
- EXPECT_TRUE(base::StartsWith(title, ASCIIToUTF16("My Dynamic Title"), true))
+ EXPECT_TRUE(base::StartsWith(title, ASCIIToUTF16("My Dynamic Title"),
+ base::CompareCase::SENSITIVE))
<< "Actual title: " << title;
}
@@ -266,7 +268,8 @@ namespace {
scoped_ptr<net::test_server::HttpResponse> NoContentResponseHandler(
const std::string& path,
const net::test_server::HttpRequest& request) {
- if (!base::StartsWithASCII(path, request.relative_url, true))
+ if (!base::StartsWith(path, request.relative_url,
+ base::CompareCase::SENSITIVE))
return scoped_ptr<net::test_server::HttpResponse>();
scoped_ptr<net::test_server::BasicHttpResponse> http_response(
@@ -443,7 +446,8 @@ namespace {
scoped_ptr<net::test_server::HttpResponse> HandleRedirectRequest(
const std::string& request_path,
const net::test_server::HttpRequest& request) {
- if (!base::StartsWithASCII(request.relative_url, request_path, true))
+ if (!base::StartsWith(request.relative_url, request_path,
+ base::CompareCase::SENSITIVE))
return scoped_ptr<net::test_server::HttpResponse>();
scoped_ptr<net::test_server::BasicHttpResponse> http_response(
« no previous file with comments | « components/storage_monitor/portable_device_watcher_win.cc ('k') | content/common/plugin_list_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698