Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: components/omnibox/suggestion_answer.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt's review comments, Mac fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/search_suggestion_parser.cc ('k') | components/omnibox/url_prefix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/suggestion_answer.cc
diff --git a/components/omnibox/suggestion_answer.cc b/components/omnibox/suggestion_answer.cc
index db6c85a5ff4c04a79bb25bf16260c9e7bd8214f9..540b73f1d47ab0a4ba1c87c2cd0eec96be005c87 100644
--- a/components/omnibox/suggestion_answer.cc
+++ b/components/omnibox/suggestion_answer.cc
@@ -107,7 +107,8 @@ bool SuggestionAnswer::ImageLine::ParseImageLine(
// but not a valid path of an URL. The GWS frontend commonly (always?)
// redirects to HTTPS so we just default to that here.
image_line->image_url_ =
- GURL(base::StartsWith(url_string, base::ASCIIToUTF16("//"), false)
+ GURL(base::StartsWith(url_string, base::ASCIIToUTF16("//"),
+ base::CompareCase::SENSITIVE)
? (base::ASCIIToUTF16(url::kHttpsScheme) +
base::ASCIIToUTF16(":") + url_string)
: url_string);
« no previous file with comments | « components/omnibox/search_suggestion_parser.cc ('k') | components/omnibox/url_prefix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698