Fix some case-insensitive cases for StartsWith

net/ftp/ftp_directory_listing_parser_vms.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_directory_listing_parser_vms.h"
 
 #include <vector>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
@@ skipping 188 matching lines @@
   // The first non-empty line is the listing header. It often
   // starts with "Directory ", but not always. We set a flag after
   // seing the header.
   bool seen_header = false;
 
   // Sometimes the listing doesn't end with a "Total" line, but
   // it's only okay when it contains some errors (it's needed
   // to distinguish it from "ls -l" format).
   bool seen_error = false;
 
+  base::string16 total_of = base::ASCIIToUTF16("Total of ");
+  base::char16 space[2] = { ' ', 0 };
   for (size_t i = 0; i < lines.size(); i++) {
     if (lines[i].empty())
       continue;
 
-    if (base::StartsWith(lines[i], base::ASCIIToUTF16("Total of "), true)) {
+    if (base::StartsWith(lines[i], total_of, base::CompareCase::SENSITIVE)) {
       // After the "total" line, all following lines must be empty.
       for (size_t j = i + 1; j < lines.size(); j++)
         if (!lines[j].empty())
           return false;
 
       return true;
     }
 
     if (!seen_header) {
       seen_header = true;
       continue;
     }
 
     if (LooksLikeVMSError(lines[i])) {
       seen_error = true;
       continue;
     }
 
-    std::vector<base::string16> columns;
-    base::SplitString(base::CollapseWhitespace(lines[i], false), ' ', &columns);
+    std::vector<base::string16> columns = base::SplitString(
+        base::CollapseWhitespace(lines[i], false), space,
+        base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
 
     if (columns.size() == 1) {
       // There can be no continuation if the current line is the last one.
       if (i == lines.size() - 1)
         return false;
 
       // Skip the next line.
       i++;
 
       // This refers to the continuation line.
       if (LooksLikeVMSError(lines[i])) {
         seen_error = true;
         continue;
       }
 
       // Join the current and next line and split them into columns.
-      base::SplitString(
+      columns = base::SplitString(
           base::CollapseWhitespace(
-              lines[i - 1] + base::ASCIIToUTF16(" ") + lines[i], false),
-          ' ',
-          &columns);
+              lines[i - 1] + space + lines[i], false),
+          space, base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
     }
 
     FtpDirectoryListingEntry entry;
     if (!ParseVmsFilename(columns[0], &entry.name, &entry.type))
       return false;
 
     // There are different variants of a VMS listing. Some display
     // the protection listing and user identification code, some do not.
     if (columns.size() == 6) {
       if (!LooksLikeVmsFileProtectionListing(columns[5]))
@@ skipping 19 matching lines @@
     entries->push_back(entry);
   }
 
   // The only place where we return true is after receiving the "Total" line,
   // that should be present in every VMS listing. Alternatively, if the listing
   // contains error messages, it's OK not to have the "Total" line.
   return seen_error;
 }
 
 }  // namespace net