a === b -> identical(a, b)

a === b -> identical(a, b)

Replace === null with == null.


BUG=http://dartbug.com/6380

Committed: https://code.google.com/p/dart/source/detail?r=14794

[danrubel, 2012-11-09 19:53:20]

the editor and analyzer changes plus a spot check of other files.... lgtm

[Lasse Reichstein Nielsen, 2012-11-12 13:10:41]

LGTM if you update at least the test lines you touch:
 Expect.equals(true, ...) => Expect.isTrue(...)
 Expect.equals(false, ...) => Expect.isFalse(...)
 Expect.isTrue(!...) => Expect.isFalse(...)
 Expect.isTrue(identical(..., ...)) => Expect.identical(..., ...)

https://codereview.chromium.org/11361190/diff/2001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/FunctionTest.dart
(left):

https://codereview.chromium.org/11361190/diff/2001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/FunctionTest.dart:310:
// FAILS: (function(a = 10) { assert(a === null); })( f() );
Commented code, just remove it.
What is this syntax? It looks like ECMAScript 6.
It won't work in checked mode, since 'function' is not a valid return type. It
has rest arguments in the test above?

Does it even work? Where is "a" declared?

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/BiIterator.dart
File samples/swarm/BiIterator.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/BiIterator.d...
samples/swarm/BiIterator.dart:61: if (identical(list[i], val)) {
Arguably this should never have been === to begin with.

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
File samples/swarm/swarm_ui_lib/observable/observable.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
samples/swarm/swarm_ui_lib/observable/observable.dart:290: //             
equality check should be done?
Remove comment. Using identical seems the right thing to do here.

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
File samples/swarm/swarm_ui_lib/touch/TouchHandler.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
samples/swarm/swarm_ui_lib/touch/TouchHandler.dart:373: static bool _xor(bool a,
bool b) => a != b;
Are we sure this isn't an attempt to do boolify on incoming non-bool values in
unchecked mode?
If we are, then consider just inlining this.

https://codereview.chromium.org/11361190/diff/2001/samples/third_party/dromae...
File samples/third_party/dromaeo/Suites.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/third_party/dromae...
samples/third_party/dromaeo/Suites.dart:95: if (null != _SUITE_DESCRIPTIONS) {
Swap operands, this is unreadable.

https://codereview.chromium.org/11361190/diff/2001/samples/third_party/dromae...
samples/third_party/dromaeo/Suites.dart:116: final name = null == variant
ditto here. And parenthesize the comparison.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart
(right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:108: if
(method != '') {
.isEmpty.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1463: // foo([a = 42)
{
missing ']'.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/map.dart
File sdk/lib/core/map.dart (right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/map.dart#newc...
sdk/lib/core/map.dart:212: (identical(_DELETED_KEY, existingKey))) {
Swap arguments.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/set.dart
File sdk/lib/core/set.dart (right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/set.dart#newc...
sdk/lib/core/set.dart:237: } while ((entry == null) || (entry === deletedKey));
Convert other === too, to identical.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/dar...
File tests/compiler/dart2js/dart2js.status (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/dar...
tests/compiler/dart2js/dart2js.status:5: identity_test: Fail # Issue 6638
Wut?
Just remove the test. It's useless anyway.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/met...
File tests/compiler/dart2js/metadata_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/met...
tests/compiler/dart2js/metadata_test.dart:47:
Expect.isTrue(!identical(annotation1, annotation2), 'expected unique
instances');
isFalse and remove the '!'.
And long line.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/met...
tests/compiler/dart2js/metadata_test.dart:100:
Expect.isTrue(!identical(annotation1, annotation2), 'expected unique
instances');
Ditto.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/moc...
File tests/compiler/dart2js/mock_compiler.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/moc...
tests/compiler/dart2js/mock_compiler.dart:138: if (identical(kind,
api.Diagnostic.ERROR)) {
Consider whether == would do, since Diagnostic probably don't override
operator==.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/res...
File tests/compiler/dart2js/resolver_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/res...
tests/compiler/dart2js/resolver_test.dart:160: Expect.isTrue(called != null);
Expect.isNotNull(called);
Ditto in other similar places.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/sca...
File tests/compiler/dart2js/scanner_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/sca...
tests/compiler/dart2js/scanner_test.dart:14: bool isRunningOnJavaScript() => 1
== 1.0;
This is true on the VM too, you really do need the 'identical' check.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_equals_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_equals_test.dart:22:
Expect.isTrue(identical(element2.kind, ElementKind.FUNCTION));
Again, consider using ==.

https://codereview.chromium.org/11361190/diff/2001/tests/isolate/serializatio...
File tests/isolate/serialization_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/isolate/serializatio...
tests/isolate/serialization_test.dart:48: Expect.isTrue(identical(copied[0],
copied[2]));
Expect.identical

https://codereview.chromium.org/11361190/diff/2001/tests/language/bool_test.dart
File tests/language/bool_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/bool_test.d...
tests/language/bool_test.dart:12: Expect.equals(true, identical(true, true));
 Expect.identical(true, true) 
and
 Expect.isFalse(identical(true, false))
Consider adding Expect.notIdentical

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
File tests/language/canonical_const2_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
tests/language/canonical_const2_test.dart:8: Expect.isTrue(!identical(const
<num>[1,2], const <num>[1.0,2.0]));
isFalse(identical

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
File tests/language/canonical_const_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
tests/language/canonical_const_test.dart:11: Expect.isTrue(identical(null,
null));
Use
 Expect.identical
and 
 Expect.isFalse(identical

https://codereview.chromium.org/11361190/diff/2001/tests/language/class_liter...
File tests/language/class_literal_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/class_liter...
tests/language/class_literal_test.dart:34: Class == null; /// 20: compile-time
error
This should not be a compile-time error any more.

https://codereview.chromium.org/11361190/diff/2001/tests/language/comparison_...
File tests/language/comparison_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/comparison_...
tests/language/comparison_test.dart:301: Expect.equals(false, Helper.EQ(1,
"eeny"));
Expect.isFalse

https://codereview.chromium.org/11361190/diff/2001/tests/language/compile_tim...
File tests/language/compile_time_constant_a_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/compile_tim...
tests/language/compile_time_constant_a_test.dart:76:
Expect.isTrue(identical(m3['m1'], m1));
Expect.identical

https://codereview.chromium.org/11361190/diff/2001/tests/language/const_local...
File tests/language/const_locals_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/const_local...
tests/language/const_locals_test.dart:22: Expect.isTrue(identical(s, 'MIN = $MIN
 MAX = $MAX  MASK = $MASK'));
Expect.identical

https://codereview.chromium.org/11361190/diff/2001/tests/language/ct_const2_t...
File tests/language/ct_const2_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/ct_const2_t...
tests/language/ct_const2_test.dart:71: const BOP10 = INT_LIT == INT_LIT_REF;
Use identical here too.
It is a compile-time constant.

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
File tests/language/first_class_types_literals_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
tests/language/first_class_types_literals_test.dart:18:
Expect.isFalse(identical(a.runtimeType, b.runtimeType));
is differentType called at all?

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
File tests/language/first_class_types_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
tests/language/first_class_types_test.dart:8: Expect.identical(a.runtimeType,
b.runtimeType);
That is not guaranteed. The runtimeType getter can give a new object each time
it's invoked.

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
tests/language/first_class_types_test.dart:14:
Expect.isFalse(identical(a.runtimeType, b.runtimeType));
Remove prints.

https://codereview.chromium.org/11361190/diff/2001/tests/language/list_litera...
File tests/language/list_literal3_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/list_litera...
tests/language/list_literal3_test.dart:20: try {
use: 
 Expect.throws(()=>joke[0] = "sock", (e) => e is UnspoortedError);

https://codereview.chromium.org/11361190/diff/2001/tests/language/list_litera...
tests/language/list_literal3_test.dart:39: Expect.equals(true, identical(a[0],
a[1]));
Expect.identical

https://codereview.chromium.org/11361190/diff/2001/tests/language/ordered_map...
File tests/language/ordered_maps_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/ordered_map...
tests/language/ordered_maps_test.dart:14: Expect.equals(true, !identical(map1,
map2));
isFalse.

https://codereview.chromium.org/11361190/diff/2001/tests/language/reg_exp2_te...
File tests/language/reg_exp2_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/reg_exp2_te...
tests/language/reg_exp2_test.dart:26: Expect.equals(true, tag != null);
isTrue

[Ivan Posva, 2012-11-12 15:46:54]

How does this differ from the CL which we had earlier about this?

-Ivan

[floitsch, 2012-11-12 15:57:53]

On 2012/11/12 15:46:54, Ivan Posva wrote:
> How does this differ from the CL which we had earlier about this?
> 
> -Ivan

There were several different CLs fixing "===". Unless there is another open CL
(that I don't know about) I assume that the other CLs just didn't change the
same files.

[floitsch, 2012-11-12 22:18:43]

https://codereview.chromium.org/11361190/diff/2001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/FunctionTest.dart
(left):

https://codereview.chromium.org/11361190/diff/2001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/FunctionTest.dart:310:
// FAILS: (function(a = 10) { assert(a === null); })( f() );
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Commented code, just remove it.
> What is this syntax? It looks like ECMAScript 6.
> It won't work in checked mode, since 'function' is not a valid return type. It
> has rest arguments in the test above?
> 
> Does it even work? Where is "a" declared?

Done.

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/BiIterator.dart
File samples/swarm/BiIterator.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/BiIterator.d...
samples/swarm/BiIterator.dart:61: if (identical(list[i], val)) {
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Arguably this should never have been === to begin with.

Maybe, but I don't know if they depend on it. Keeping as is.

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
File samples/swarm/swarm_ui_lib/observable/observable.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
samples/swarm/swarm_ui_lib/observable/observable.dart:290: //             
equality check should be done?
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Remove comment. Using identical seems the right thing to do here.

Done.

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
File samples/swarm/swarm_ui_lib/touch/TouchHandler.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/swarm/swarm_ui_lib...
samples/swarm/swarm_ui_lib/touch/TouchHandler.dart:373: static bool _xor(bool a,
bool b) => a != b;
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Are we sure this isn't an attempt to do boolify on incoming non-bool values in
> unchecked mode?
> If we are, then consider just inlining this.

Afaics the only use is in line 366. Not inlining, since "xor" may reflect better
the purpose.

https://codereview.chromium.org/11361190/diff/2001/samples/third_party/dromae...
File samples/third_party/dromaeo/Suites.dart (right):

https://codereview.chromium.org/11361190/diff/2001/samples/third_party/dromae...
samples/third_party/dromaeo/Suites.dart:95: if (null != _SUITE_DESCRIPTIONS) {
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Swap operands, this is unreadable.

Done.

https://codereview.chromium.org/11361190/diff/2001/samples/third_party/dromae...
samples/third_party/dromaeo/Suites.dart:116: final name = null == variant
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> ditto here. And parenthesize the comparison.

Done.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart
(right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:108: if
(method != '') {
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> .isEmpty.
Actually inside a string (thus JavaScript code). Reverting this change.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1463: // foo([a = 42)
{
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> missing ']'.

Done.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/map.dart
File sdk/lib/core/map.dart (right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/map.dart#newc...
sdk/lib/core/map.dart:212: (identical(_DELETED_KEY, existingKey))) {
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Swap arguments.

Done.

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/set.dart
File sdk/lib/core/set.dart (right):

https://codereview.chromium.org/11361190/diff/2001/sdk/lib/core/set.dart#newc...
sdk/lib/core/set.dart:237: } while ((entry == null) || (entry === deletedKey));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Convert other === too, to identical.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/dar...
File tests/compiler/dart2js/dart2js.status (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/dar...
tests/compiler/dart2js/dart2js.status:5: identity_test: Fail # Issue 6638
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Wut?
> Just remove the test. It's useless anyway.

It tests if we optimize the identity function. As discussed, keeping it.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/met...
File tests/compiler/dart2js/metadata_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/met...
tests/compiler/dart2js/metadata_test.dart:47:
Expect.isTrue(!identical(annotation1, annotation2), 'expected unique
instances');
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> isFalse and remove the '!'.
> And long line.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/met...
tests/compiler/dart2js/metadata_test.dart:100:
Expect.isTrue(!identical(annotation1, annotation2), 'expected unique
instances');
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Ditto.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/moc...
File tests/compiler/dart2js/mock_compiler.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/moc...
tests/compiler/dart2js/mock_compiler.dart:138: if (identical(kind,
api.Diagnostic.ERROR)) {
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Consider whether == would do, since Diagnostic probably don't override
> operator==.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/res...
File tests/compiler/dart2js/resolver_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/res...
tests/compiler/dart2js/resolver_test.dart:160: Expect.isTrue(called != null);
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Expect.isNotNull(called);
> Ditto in other similar places.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/sca...
File tests/compiler/dart2js/scanner_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/sca...
tests/compiler/dart2js/scanner_test.dart:14: bool isRunningOnJavaScript() => 1
== 1.0;
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> This is true on the VM too, you really do need the 'identical' check.
argh.
done.

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_equals_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_equals_test.dart:22:
Expect.isTrue(identical(element2.kind, ElementKind.FUNCTION));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Again, consider using ==.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/isolate/serializatio...
File tests/isolate/serialization_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/isolate/serializatio...
tests/isolate/serialization_test.dart:48: Expect.isTrue(identical(copied[0],
copied[2]));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Expect.identical

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/bool_test.dart
File tests/language/bool_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/bool_test.d...
tests/language/bool_test.dart:12: Expect.equals(true, identical(true, true));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
>  Expect.identical(true, true) 
> and
>  Expect.isFalse(identical(true, false))
> Consider adding Expect.notIdentical
> 
Changed to .isTrue / .isFalse.
Kept the identicals. We don't want to go through the Expect to do the identical
check. (This is one of the most basic tests).

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
File tests/language/canonical_const2_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
tests/language/canonical_const2_test.dart:8: Expect.isTrue(!identical(const
<num>[1,2], const <num>[1.0,2.0]));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> isFalse(identical

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
File tests/language/canonical_const_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/canonical_c...
tests/language/canonical_const_test.dart:11: Expect.isTrue(identical(null,
null));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Use
>  Expect.identical
> and 
>  Expect.isFalse(identical

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/class_liter...
File tests/language/class_literal_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/class_liter...
tests/language/class_literal_test.dart:34: Class == null; /// 20: compile-time
error
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> This should not be a compile-time error any more.

Different CL.

https://codereview.chromium.org/11361190/diff/2001/tests/language/comparison_...
File tests/language/comparison_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/comparison_...
tests/language/comparison_test.dart:301: Expect.equals(false, Helper.EQ(1,
"eeny"));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Expect.isFalse

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/compile_tim...
File tests/language/compile_time_constant_a_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/compile_tim...
tests/language/compile_time_constant_a_test.dart:76:
Expect.isTrue(identical(m3['m1'], m1));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Expect.identical

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/const_local...
File tests/language/const_locals_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/const_local...
tests/language/const_locals_test.dart:22: Expect.isTrue(identical(s, 'MIN = $MIN
 MAX = $MAX  MASK = $MASK'));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Expect.identical

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/ct_const2_t...
File tests/language/ct_const2_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/ct_const2_t...
tests/language/ct_const2_test.dart:71: const BOP10 = INT_LIT == INT_LIT_REF;
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Use identical here too.
> It is a compile-time constant.
identical doesn't yet work on compile-time constants. Not sure if it supposed to
be.

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
File tests/language/first_class_types_literals_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
tests/language/first_class_types_literals_test.dart:18:
Expect.isFalse(identical(a.runtimeType, b.runtimeType));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> is differentType called at all?

No. removed.

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
File tests/language/first_class_types_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
tests/language/first_class_types_test.dart:8: Expect.identical(a.runtimeType,
b.runtimeType);
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> That is not guaranteed. The runtimeType getter can give a new object each time
> it's invoked.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/first_class...
tests/language/first_class_types_test.dart:14:
Expect.isFalse(identical(a.runtimeType, b.runtimeType));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Remove prints.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/list_litera...
File tests/language/list_literal3_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/list_litera...
tests/language/list_literal3_test.dart:20: try {
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> use: 
>  Expect.throws(()=>joke[0] = "sock", (e) => e is UnspoortedError);

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/list_litera...
tests/language/list_literal3_test.dart:39: Expect.equals(true, identical(a[0],
a[1]));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> Expect.identical

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/ordered_map...
File tests/language/ordered_maps_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/ordered_map...
tests/language/ordered_maps_test.dart:14: Expect.equals(true, !identical(map1,
map2));
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> isFalse.

Done.

https://codereview.chromium.org/11361190/diff/2001/tests/language/reg_exp2_te...
File tests/language/reg_exp2_test.dart (right):

https://codereview.chromium.org/11361190/diff/2001/tests/language/reg_exp2_te...
tests/language/reg_exp2_test.dart:26: Expect.equals(true, tag != null);
On 2012/11/12 13:10:41, Lasse Reichstein Nielsen wrote:
> isTrue
isNotNull
done.