sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/interceptors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

index 34d36bc30cdc5a0230df1c4578d6233fe4fbf324..b31e471a9cc33d90d851f047501a0bce8f156906 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -75,7 +75,7 @@ class SendVisitor extends ResolvedVisitor {

visitGetterSend(Send node) {

final element = elements[node];

- // element === null means dynamic property access.

+ // element == null means dynamic property access.

if (element == null) {

collector.tryMakeMemberPlaceholder(node.selector);

} else if (element.isErroneous()) {

@@ -211,7 +211,7 @@ class PlaceholderCollector extends Visitor {

VariableDefinitions definitions = elementNode;

for (Node definition in definitions.definitions) {

final definitionElement = treeElements[definition];

- // definitionElement === null if variable is actually unused.

+ // definitionElement == null if variable is actually unused.

if (definitionElement == null) continue;

collectFieldDeclarationPlaceholders(definitionElement, definition);

}