Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: runtime/bin/process_patch.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/eventhandler_patch.dart ('k') | runtime/bin/socket_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_patch.dart
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
index 1dd8bf63ea34589da7958c16c4c21aa6266e5c23..ff99345f4a2b4c75e82e628c36b5bef6f2e6f6ed 100644
--- a/runtime/bin/process_patch.dart
+++ b/runtime/bin/process_patch.dart
@@ -52,7 +52,7 @@ class _ProcessImpl extends NativeFieldWrapperClass1 implements Process {
}
}
- if (options !== null && options.workingDirectory !== null) {
+ if (options != null && options.workingDirectory != null) {
_workingDirectory = options.workingDirectory;
if (_workingDirectory is !String) {
throw new ArgumentError(
@@ -60,7 +60,7 @@ class _ProcessImpl extends NativeFieldWrapperClass1 implements Process {
}
}
- if (options !== null && options.environment !== null) {
+ if (options != null && options.environment != null) {
var env = options.environment;
if (env is !Map) {
throw new ArgumentError("Environment is not a map: $env");
@@ -190,7 +190,7 @@ class _ProcessImpl extends NativeFieldWrapperClass1 implements Process {
void handleExit() {
_ended = true;
- if (_onExit !== null) {
+ if (_onExit != null) {
_onExit(exitCode(exitDataBuffer));
}
_out.close();
@@ -277,15 +277,15 @@ class _NonInteractiveProcess {
// Extract output encoding options and verify arguments.
var stdoutEncoding = Encoding.UTF_8;
var stderrEncoding = Encoding.UTF_8;
- if (options !== null) {
- if (options.stdoutEncoding !== null) {
+ if (options != null) {
+ if (options.stdoutEncoding != null) {
stdoutEncoding = options.stdoutEncoding;
if (stdoutEncoding is !Encoding) {
throw new ArgumentError(
'stdoutEncoding option is not an encoding: $stdoutEncoding');
}
}
- if (options.stderrEncoding !== null) {
+ if (options.stderrEncoding != null) {
stderrEncoding = options.stderrEncoding;
if (stderrEncoding is !Encoding) {
throw new ArgumentError(
« no previous file with comments | « runtime/bin/eventhandler_patch.dart ('k') | runtime/bin/socket_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698