tests/language/const_locals_test.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/language/const_locals_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/language/const_locals_test.dart

diff --git a/tests/language/const_locals_test.dart b/tests/language/const_locals_test.dart

index 9d7e6689413adad8ee15dd6792d2b7c0c48beeb9..4c57168fe1c741caf597c4d603dc1c9b68f4fc6a 100644

--- a/tests/language/const_locals_test.dart

+++ b/tests/language/const_locals_test.dart

@@ -19,13 +19,13 @@ main() {

Expect.equals(16, MAX);

Expect.equals(65535, MASK);

const s = 'MIN = $MIN MAX = $MAX MASK = $MASK';

- Expect.isTrue(s === 'MIN = $MIN MAX = $MAX MASK = $MASK');

+ Expect.identical(s, 'MIN = $MIN MAX = $MAX MASK = $MASK');

Expect.equals("MIN = 1 MAX = 16 MASK = 65535", s);

var cf1 = const ConstFoo(MASK);

var cf2 = const ConstFoo(s);

var cf3 = const ConstFoo('MIN = $MIN MAX = $MAX MASK = $MASK');

- Expect.isTrue(cf2 === cf3);

- Expect.isFalse(cf2 === cf1);

+ Expect.identical(cf2, cf3);

+ Expect.isFalse(identical(cf2, cf1));

}