sdk/lib/io/file_impl.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/file_impl.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/file_impl.dart

diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart

index 05126a8bbf09f38f7a94fb3a0db3d2f737605cf5..63c161b3138389ac7edf097929b35d07372d2913 100644

--- a/sdk/lib/io/file_impl.dart

+++ b/sdk/lib/io/file_impl.dart

@@ -249,10 +249,10 @@ class _FileOutputStream extends _BaseOutputStream implements OutputStream {

void _processPendingOperations() {

_pendingOperations.forEach((buffer) {

if (buffer is _PendingOperation) {

- if (buffer === _PendingOperation.CLOSE) {

+ if (identical(buffer, _PendingOperation.CLOSE)) {

close();

} else {

- assert(buffer === _PendingOperation.FLUSH);

+ assert(identical(buffer, _PendingOperation.FLUSH));

flush();

}

} else {

« no previous file with comments | « sdk/lib/io/chunked_stream.dart ('k') | sdk/lib/io/http_impl.dart » ('j') | no next file with comments »