Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/logging/test/logging_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/logging/test/logging_test.dart
diff --git a/pkg/logging/test/logging_test.dart b/pkg/logging/test/logging_test.dart
index 37518b124baf6732dccd1a7633f3d7e8c1dc3782..fe1c4f0e5d24626a5a7402f0e98196dc0e5f2f3f 100644
--- a/pkg/logging/test/logging_test.dart
+++ b/pkg/logging/test/logging_test.dart
@@ -25,7 +25,7 @@ main() {
expect(level2 > level1, isTrue);
var level3 = const Level('NOT_REAL3', 253);
- expect(level1 !== level3, isTrue); // different instances
+ expect(!identical(level1, level3), isTrue); // different instances
expect(level1 == level3, isTrue); // same value.
});
@@ -102,10 +102,10 @@ main() {
Logger a2 = new Logger('a');
Logger b = new Logger('a.b');
Logger root = Logger.root;
- expect(a1 === a2, isTrue);
- expect(a1 === b.parent, isTrue);
- expect(root === a1.parent, isTrue);
- expect(root === new Logger(''), isTrue);
+ expect(identical(a1, a2), isTrue);
+ expect(identical(a1, b.parent), isTrue);
+ expect(identical(root, a1.parent), isTrue);
+ expect(identical(root, new Logger('')), isTrue);
});
group('mutating levels', () {

Powered by Google App Engine
This is Rietveld 408576698