sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

index 42f64939c667c4e28180e546749d0de91dc8d081..6b8df4f83849ff3703f7b72bfc58b4ad3d96e711 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

@@ -5,7 +5,7 @@

List regExpExec(JSSyntaxRegExp regExp, String str) {

var nativeRegExp = regExpGetNative(regExp);

var result = JS('List', r'#.exec(#)', nativeRegExp, str);

- if (JS('bool', r'# === null', result)) return null;

+ if (JS('bool', r'# == null', result)) return null;

return result;

}