tests/compiler/dart2js_extra/nan_negate_test.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js_extra/nan_negate_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/compiler/dart2js_extra/literal_string_juxtaposition_test.dart ('k') | tests/compiler/dart2js_extra/no_such_method_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js_extra/nan_negate_test.dart

diff --git a/tests/compiler/dart2js_extra/nan_negate_test.dart b/tests/compiler/dart2js_extra/nan_negate_test.dart

index 87519cdb258d5e09950dcf98247909c928bafb45..1d86387da471e755415359f9bd0f1fda7e67771d 100644

--- a/tests/compiler/dart2js_extra/nan_negate_test.dart

+++ b/tests/compiler/dart2js_extra/nan_negate_test.dart

@@ -24,11 +24,11 @@ test(double n) {

Expect.isTrue(n != 0);

Expect.isTrue(!(n == 0));

- Expect.isFalse(n === 0);

- Expect.isFalse(!(n !== 0));

+ Expect.isFalse(identical(n, 0));

+ Expect.isFalse(!(!identical(n, 0)));

- Expect.isTrue(n !== 0);

- Expect.isTrue(!(n === 0));

+ Expect.isTrue(!identical(n, 0));

+ Expect.isTrue(!(identical(n, 0)));

Expect.isFalse(0 >= n);

Expect.isTrue(!(0 < n));

@@ -48,11 +48,11 @@ test(double n) {

Expect.isTrue(0 != n);

Expect.isTrue(!(0 == n));

- Expect.isFalse(0 === n);

- Expect.isFalse(!(0 !== n));

+ Expect.isFalse(identical(0, n));

+ Expect.isFalse(!(!identical(0, n)));

- Expect.isTrue(0 !== n);

- Expect.isTrue(!(0 === n));

+ Expect.isTrue(!identical(0, n));

+ Expect.isTrue(!(identical(0, n)));

}

testConstant() {

@@ -74,11 +74,11 @@ testConstant() {

Expect.isTrue(double.NAN != 0);

Expect.isTrue(!(double.NAN == 0));

- Expect.isFalse(double.NAN === 0);

- Expect.isFalse(!(double.NAN !== 0));

+ Expect.isFalse(identical(double.NAN, 0));

+ Expect.isFalse(!(!identical(double.NAN, 0)));

- Expect.isTrue(double.NAN !== 0);

- Expect.isTrue(!(double.NAN === 0));

+ Expect.isTrue(!identical(double.NAN, 0));

+ Expect.isTrue(!(identical(double.NAN, 0)));

Expect.isFalse(0 >= double.NAN);

Expect.isTrue(!(0 < double.NAN));

@@ -98,11 +98,11 @@ testConstant() {

Expect.isTrue(0 != double.NAN);

Expect.isTrue(!(0 == double.NAN));

- Expect.isFalse(0 === double.NAN);

- Expect.isFalse(!(0 !== double.NAN));

+ Expect.isFalse(identical(0, double.NAN));

+ Expect.isFalse(!(!identical(0, double.NAN)));

- Expect.isTrue(0 !== double.NAN);

- Expect.isTrue(!(0 === double.NAN));

+ Expect.isTrue(!identical(0, double.NAN));

+ Expect.isTrue(!(identical(0, double.NAN)));

}

main() {