Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: tests/compiler/dart2js/metadata_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/identity_test.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/metadata_test.dart
diff --git a/tests/compiler/dart2js/metadata_test.dart b/tests/compiler/dart2js/metadata_test.dart
index df35845a0e3098ff23fdeb10c8ab0166d6bc30dd..79a0595d5095170ab6af6fd6175f3f8198ea2c18 100644
--- a/tests/compiler/dart2js/metadata_test.dart
+++ b/tests/compiler/dart2js/metadata_test.dart
@@ -44,7 +44,8 @@ void checkAnnotation(String name, String declaration,
MetadataAnnotation annotation2 = element.metadata.tail.head;
annotation1.ensureResolved(compiler);
annotation2.ensureResolved(compiler);
- Expect.isTrue(annotation1 !== annotation2, 'expected unique instances');
+ Expect.isFalse(identical(annotation1, annotation2),
+ 'expected unique instances');
Expect.notEquals(annotation1, annotation2, 'expected unequal instances');
Constant value1 = annotation1.value;
Constant value2 = annotation2.value;
@@ -97,7 +98,8 @@ void checkAnnotation(String name, String declaration,
MetadataAnnotation annotation2 = element.metadata.tail.head;
annotation1.ensureResolved(compiler);
annotation2.ensureResolved(compiler);
- Expect.isTrue(annotation1 !== annotation2, 'expected unique instances');
+ Expect.isFalse(identical(annotation1, annotation2),
+ 'expected unique instances');
Expect.notEquals(annotation1, annotation2, 'expected unequal instances');
Constant value1 = annotation1.value;
Constant value2 = annotation2.value;
« no previous file with comments | « tests/compiler/dart2js/identity_test.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698