Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index afd2a0bbaac0ac509423f8ccc5c64c0452250ae5..8e6f6cbd07a9310068e60e43dd5e08abdc6004c6 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -1301,7 +1301,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
Node node = member.parseNode(compiler);
SendSet assignment = node.asSendSet();
HInstruction value;
- if (assignment === null) {
+ if (assignment == null) {
value = graph.addConstantNull(constantSystem);
} else {
Node right = assignment.arguments.head;
@@ -1460,12 +1460,12 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
// This is the code we emit for a parameter that is being checked
// on whether it was given at value at the call site:
//
- // foo([a = 42) {
+ // foo([a = 42]) {
// if (?a) print('parameter passed $a');
// }
//
// foo([a = 42]) {
- // var t1 = a === sentinel;
+ // var t1 = identical(a, sentinel);
// if (t1) a = 42;
// if (!t1) print('parameter passed ' + a);
// }

Powered by Google App Engine
This is Rietveld 408576698