Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/testing/dart/drt_updater.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/utils/utf8_test.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/drt_updater.dart
diff --git a/tools/testing/dart/drt_updater.dart b/tools/testing/dart/drt_updater.dart
index 6713a88db761e889ed2adfa0aa73befa37251e80..c0482631039e40c10204ea08010fd039f43b3378 100644
--- a/tools/testing/dart/drt_updater.dart
+++ b/tools/testing/dart/drt_updater.dart
@@ -39,7 +39,7 @@ class _DartiumUpdater {
Path testScriptPath = new Path.fromNative(TestUtils.testScriptPath);
Path updateScriptPath = testScriptPath.directoryPath.append(script);
List<String> command = [updateScriptPath.toNativePath()];
- if (null !== option) {
+ if (null != option) {
command.add(option);
}
return command;
@@ -66,14 +66,14 @@ _DartiumUpdater runtimeUpdater(Map configuration) {
String runtime = configuration['runtime'];
if (runtime == 'drt' && configuration['drt'] == '') {
// Download the default DumpRenderTree from Google Storage.
- if (_dumpRenderTreeUpdater === null) {
+ if (_dumpRenderTreeUpdater == null) {
_dumpRenderTreeUpdater = new _DartiumUpdater('DumpRenderTree',
'get_archive.py', 'drt');
}
return _dumpRenderTreeUpdater;
} else if (runtime == 'dartium' && configuration['dartium'] == '') {
// Download the default Dartium from Google Storage.
- if (_dartiumUpdater === null) {
+ if (_dartiumUpdater == null) {
_dartiumUpdater = new _DartiumUpdater('Dartium Chrome', 'get_archive.py',
'dartium');
}
« no previous file with comments | « tests/utils/utf8_test.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698