Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: pkg/logging/test/logging_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 library logging_test; 6 library logging_test;
7 7
8 // TODO(rnystrom): Use "package:" import when test.dart supports it (#4968). 8 // TODO(rnystrom): Use "package:" import when test.dart supports it (#4968).
9 import '../lib/logging.dart'; 9 import '../lib/logging.dart';
10 import '../../../pkg/unittest/lib/unittest.dart'; 10 import '../../../pkg/unittest/lib/unittest.dart';
11 11
12 main() { 12 main() {
13 test('level comparison is a valid comparator', () { 13 test('level comparison is a valid comparator', () {
14 var level1 = const Level('NOT_REAL1', 253); 14 var level1 = const Level('NOT_REAL1', 253);
15 expect(level1 == level1, isTrue); 15 expect(level1 == level1, isTrue);
16 expect(level1 <= level1, isTrue); 16 expect(level1 <= level1, isTrue);
17 expect(level1 >= level1, isTrue); 17 expect(level1 >= level1, isTrue);
18 expect(level1 < level1, isFalse); 18 expect(level1 < level1, isFalse);
19 expect(level1 > level1, isFalse); 19 expect(level1 > level1, isFalse);
20 20
21 var level2 = const Level('NOT_REAL2', 455); 21 var level2 = const Level('NOT_REAL2', 455);
22 expect(level1 <= level2, isTrue); 22 expect(level1 <= level2, isTrue);
23 expect(level1 < level2, isTrue); 23 expect(level1 < level2, isTrue);
24 expect(level2 >= level1, isTrue); 24 expect(level2 >= level1, isTrue);
25 expect(level2 > level1, isTrue); 25 expect(level2 > level1, isTrue);
26 26
27 var level3 = const Level('NOT_REAL3', 253); 27 var level3 = const Level('NOT_REAL3', 253);
28 expect(level1 !== level3, isTrue); // different instances 28 expect(!identical(level1, level3), isTrue); // different instances
29 expect(level1 == level3, isTrue); // same value. 29 expect(level1 == level3, isTrue); // same value.
30 }); 30 });
31 31
32 test('default levels are in order', () { 32 test('default levels are in order', () {
33 final levels = const [ 33 final levels = const [
34 Level.ALL, Level.FINEST, Level.FINER, Level.FINE, Level.CONFIG, 34 Level.ALL, Level.FINEST, Level.FINER, Level.FINE, Level.CONFIG,
35 Level.INFO, Level.WARNING, Level.SEVERE, Level.SHOUT, Level.OFF 35 Level.INFO, Level.WARNING, Level.SEVERE, Level.SHOUT, Level.OFF
36 ]; 36 ];
37 37
38 for (int i = 0; i < levels.length; i++) { 38 for (int i = 0; i < levels.length; i++) {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 expect(a == c.parent, isTrue); 95 expect(a == c.parent, isTrue);
96 expect(a.children['b'] == b, isTrue); 96 expect(a.children['b'] == b, isTrue);
97 expect(a.children['c'] == c, isTrue); 97 expect(a.children['c'] == c, isTrue);
98 }); 98 });
99 99
100 test('loggers are singletons', () { 100 test('loggers are singletons', () {
101 Logger a1 = new Logger('a'); 101 Logger a1 = new Logger('a');
102 Logger a2 = new Logger('a'); 102 Logger a2 = new Logger('a');
103 Logger b = new Logger('a.b'); 103 Logger b = new Logger('a.b');
104 Logger root = Logger.root; 104 Logger root = Logger.root;
105 expect(a1 === a2, isTrue); 105 expect(identical(a1, a2), isTrue);
106 expect(a1 === b.parent, isTrue); 106 expect(identical(a1, b.parent), isTrue);
107 expect(root === a1.parent, isTrue); 107 expect(identical(root, a1.parent), isTrue);
108 expect(root === new Logger(''), isTrue); 108 expect(identical(root, new Logger('')), isTrue);
109 }); 109 });
110 110
111 group('mutating levels', () { 111 group('mutating levels', () {
112 Logger root = Logger.root; 112 Logger root = Logger.root;
113 Logger a = new Logger('a'); 113 Logger a = new Logger('a');
114 Logger b = new Logger('a.b'); 114 Logger b = new Logger('a.b');
115 Logger c = new Logger('a.b.c'); 115 Logger c = new Logger('a.b.c');
116 Logger d = new Logger('a.b.c.d'); 116 Logger d = new Logger('a.b.c.d');
117 Logger e = new Logger('a.b.c.d.e'); 117 Logger e = new Logger('a.b.c.d.e');
118 118
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 'SHOUT: 10'])); 328 'SHOUT: 10']));
329 329
330 expect(cMessages, equals([ 330 expect(cMessages, equals([
331 // 1 - 7 are lower in the hierarchy 331 // 1 - 7 are lower in the hierarchy
332 // 'FINE: 8' is not loggable 332 // 'FINE: 8' is not loggable
333 'WARNING: 9', 333 'WARNING: 9',
334 'SHOUT: 10'])); 334 'SHOUT: 10']));
335 }); 335 });
336 }); 336 });
337 } 337 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698