Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: tests/language/const_string_test.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/const_nested_test.dart ('k') | tests/language/constant_fold_equals_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/const_string_test.dart
diff --git a/tests/language/const_string_test.dart b/tests/language/const_string_test.dart
index 720fb37dbd1d44ce436fc9d9aad41d1125a5569b..feecc8809f4da4560fac8dea35460a69e24ba022 100644
--- a/tests/language/const_string_test.dart
+++ b/tests/language/const_string_test.dart
@@ -6,30 +6,30 @@
main() {
// Constant comparisons are independent of the quotes used.
- Expect.isTrue("abcd" === 'abcd');
- Expect.isTrue('abcd' === "abcd");
- Expect.isTrue("ab\"cd" === 'ab"cd');
- Expect.isTrue('ab\'cd' === "ab'cd");
+ Expect.isTrue(identical("abcd", 'abcd'));
+ Expect.isTrue(identical('abcd', "abcd"));
+ Expect.isTrue(identical("ab\"cd", 'ab"cd'));
+ Expect.isTrue(identical('ab\'cd', "ab'cd"));
// String concatenation works even when quotes are different.
- Expect.isTrue("abcd" === "ab" "cd");
- Expect.isTrue("abcd" === "ab" 'cd');
- Expect.isTrue("abcd" === 'ab' 'cd');
- Expect.isTrue("abcd" === 'ab' "cd");
+ Expect.isTrue(identical("abcd", "ab" "cd"));
+ Expect.isTrue(identical("abcd", "ab" 'cd'));
+ Expect.isTrue(identical("abcd", 'ab' 'cd'));
+ Expect.isTrue(identical("abcd", 'ab' "cd"));
// Or when there are more than 2 contatenations.
- Expect.isTrue("abcd" === "a" "b" "cd");
- Expect.isTrue("abcd" === "a" "b" "c" "d");
- Expect.isTrue('abcd' === 'a' 'b' 'c' 'd');
- Expect.isTrue("abcd" === "a" "b" 'c' "d");
- Expect.isTrue("abcd" === 'a' 'b' 'c' 'd');
- Expect.isTrue("abcd" === 'a' "b" 'c' "d");
+ Expect.isTrue(identical("abcd", "a" "b" "cd"));
+ Expect.isTrue(identical("abcd", "a" "b" "c" "d"));
+ Expect.isTrue(identical('abcd', 'a' 'b' 'c' 'd'));
+ Expect.isTrue(identical("abcd", "a" "b" 'c' "d"));
+ Expect.isTrue(identical("abcd", 'a' 'b' 'c' 'd'));
+ Expect.isTrue(identical("abcd", 'a' "b" 'c' "d"));
- Expect.isTrue("a'b'cd" === "a" "'b'" 'c' "d");
- Expect.isTrue("a\"b\"cd" === "a" '"b"' 'c' "d");
- Expect.isTrue("a\"b\"cd" === "a" '"b"' 'c' "d");
- Expect.isTrue("a'b'cd" === 'a' "'b'" 'c' "d");
- Expect.isTrue('a\'b\'cd' === "a" "'b'" 'c' "d");
- Expect.isTrue('a"b"cd' === 'a' '"b"' 'c' "d");
- Expect.isTrue("a\"b\"cd" === 'a' '"b"' 'c' "d");
+ Expect.isTrue(identical("a'b'cd", "a" "'b'" 'c' "d"));
+ Expect.isTrue(identical("a\"b\"cd", "a" '"b"' 'c' "d"));
+ Expect.isTrue(identical("a\"b\"cd", "a" '"b"' 'c' "d"));
+ Expect.isTrue(identical("a'b'cd", 'a' "'b'" 'c' "d"));
+ Expect.isTrue(identical('a\'b\'cd', "a" "'b'" 'c' "d"));
+ Expect.isTrue(identical('a"b"cd', 'a' '"b"' 'c' "d"));
+ Expect.isTrue(identical("a\"b\"cd", 'a' '"b"' 'c' "d"));
}
« no previous file with comments | « tests/language/const_nested_test.dart ('k') | tests/language/constant_fold_equals_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698