sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart - Issue 11361190: a === b -> identical(a, b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart

Issue 11361190: a === b -> identical(a, b) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart b/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart

index 88d9fea4177f1d773af631b0f4c864a10ba34500..a0e3382fd9420c84e5b01c136c5202fe3fb677ae 100644

--- a/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart

+++ b/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart

@@ -1136,7 +1136,7 @@ class TypeInferrerVisitor extends ResolvedVisitor<ConcreteType> {

ConcreteType visitReturn(Return node) {

final expression = node.expression;

- return (expression === null)

+ return (expression == null)

? new ConcreteType.singleton(const NullBaseType())

: analyze(expression);

}

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/validate.dart ('k') | sdk/lib/collection/arrays.dart » ('j') | no next file with comments »