Pure pedantry: Replace all ".size() == 0" with ".empty()".

Pure pedantry: Replace all ".size() == 0" with ".empty()".

BUG=carnitas
TEST=compiles; existing unit tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76467

[Elliot Glaysher, 2011-03-01 22:29:27]

This patch is one giant nit repeated a hundred times.

[Peter Kasting, 2011-03-01 22:31:08]

Awesome!

Can you also catch "size() > 0" and "size() != 0" and turn then into "!empty()"?

[dmaclach1, 2011-03-01 22:35:06]

worth adding something to the presubmit scripts? or clang plugin?

On Tue, Mar 1, 2011 at 2:31 PM,  <pkasting@chromium.org> wrote:
> Awesome!
>
> Can you also catch "size() > 0" and "size() != 0" and turn then into
> "!empty()"?
>
> http://codereview.chromium.org/6602049/
>

[Elliot Glaysher, 2011-03-01 22:40:54]

On Tue, Mar 1, 2011 at 2:34 PM, David Maclachlan <dmaclach@google.com> wrote:
> worth adding something to the presubmit scripts? or clang plugin?

Probably, but I'm not entirely sure how I'd implement it. My regexp
that I used to find these had a ton of false positives and I haven't
done any attempts at reading the contents of a function in a clang
plugin yet...

>> http://codereview.chromium.org/6602049/

[Ben Goodger (Google), 2011-03-01 22:50:52]

I am going to let Peter review this as I am very busy right now :-)

-Ben

On Tue, Mar 1, 2011 at 2:40 PM, Elliot Glaysher (Chromium) <erg@chromium.org
> wrote:

> On Tue, Mar 1, 2011 at 2:34 PM, David Maclachlan <dmaclach@google.com>
> wrote:
> > worth adding something to the presubmit scripts? or clang plugin?
>
> Probably, but I'm not entirely sure how I'd implement it. My regexp
> that I used to find these had a ton of false positives and I haven't
> done any attempts at reading the contents of a function in a clang
> plugin yet...
>
> >> http://codereview.chromium.org/6602049/
>

[Peter Kasting, 2011-03-02 00:02:42]

LGTM but because it's me you get a bunch of tagalong nits for cleanup of
adjacent code.

http://codereview.chromium.org/6602049/diff/1/base/command_line_unittest.cc
File base/command_line_unittest.cc (right):

http://codereview.chromium.org/6602049/diff/1/base/command_line_unittest.cc#n...
base/command_line_unittest.cc:112: EXPECT_EQ(0U, cl.argv().size());
Nit: EXPECT_TRUE(cl.argv().empty()); (2 places)

http://codereview.chromium.org/6602049/diff/1/base/file_path.cc
File base/file_path.cc (right):

http://codereview.chromium.org/6602049/diff/1/base/file_path.cc#newcode252
base/file_path.cc:252: if (parent_components.size() >= child_components.size())
Nit: Seems like these could be combined

http://codereview.chromium.org/6602049/diff/1/base/string_util.cc
File base/string_util.cc (right):

http://codereview.chromium.org/6602049/diff/1/base/string_util.cc#newcode807
base/string_util.cc:807: if (parts.empty()) return STR();
Nit: Style: return goes on separate line

http://codereview.chromium.org/6602049/diff/1/base/string_util.cc#newcode810
base/string_util.cc:810: typename std::vector<STR>::const_iterator iter =
parts.begin();
Nit: While here:

  STR result(parts[0]);
  for (std::vector<STR>::const_iterator i(parts.begin() + 1); i != parts.end();
       ++i)
    result += sep + *iter;
  return result;

http://codereview.chromium.org/6602049/diff/1/chrome/browser/bookmarks/bookma...
File chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm (right):

http://codereview.chromium.org/6602049/diff/1/chrome/browser/bookmarks/bookma...
chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm:227: if
(elements.empty()) {
Nit: No {} (file style)

http://codereview.chromium.org/6602049/diff/1/chrome/browser/password_manager...
File chrome/browser/password_manager/password_store_mac.cc (right):

http://codereview.chromium.org/6602049/diff/1/chrome/browser/password_manager...
chrome/browser/password_manager/password_store_mac.cc:519: return matches.size()
!= 0;
Nit: !empty()

http://codereview.chromium.org/6602049/diff/1/chrome/common/unix_domain_socke...
File chrome/common/unix_domain_socket_posix.cc (right):

http://codereview.chromium.org/6602049/diff/1/chrome/common/unix_domain_socke...
chrome/common/unix_domain_socket_posix.cc:142: if (fd_vector.empty()) {
Nit:

    *result_fd = fd_vector.empty() ? -1 : fd_vector[0];

http://codereview.chromium.org/6602049/diff/1/o3d/core/cross/gpu2d/interval_t...
File o3d/core/cross/gpu2d/interval_tree_test.cc (right):

http://codereview.chromium.org/6602049/diff/1/o3d/core/cross/gpu2d/interval_t...
o3d/core/cross/gpu2d/interval_tree_test.cc:179: bool add = false;
Nit: Eliminate |add| and condense to:

    if (added_elements.empty() ||
        (!removed_elements.empty() && (NextRandom(2) == 1))) {
      ...
    } else {
      ...

http://codereview.chromium.org/6602049/diff/1/o3d/core/cross/gpu2d/path_proce...
File o3d/core/cross/gpu2d/path_processor.cc (right):

http://codereview.chromium.org/6602049/diff/1/o3d/core/cross/gpu2d/path_proce...
o3d/core/cross/gpu2d/path_processor.cc:1108: if (cur_segments.empty()) {
Nit: "break;  // Done" would allow eliminating {} (2 places)

http://codereview.chromium.org/6602049/diff/1/o3d/utils/cross/text_reader.cc
File o3d/utils/cross/text_reader.cc (right):

http://codereview.chromium.org/6602049/diff/1/o3d/utils/cross/text_reader.cc#...
o3d/utils/cross/text_reader.cc:51: if (eol.empty()) {
Nit: Eliminate anonymous namespace of consts and collapse to:

  if (!eol.empty()) {
    if (eol[0] == '\n')
      return 1;
    if (eol[0] == '\r')
      return ((eol.size() > 1) && (eol[1] == '\n')) ? 2 : 1;
  }
  return 0;