Pure pedantry: Replace all ".size() == 0" with ".empty()".

base/string_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 
 #include "build/build_config.h"
 
 #include <ctype.h>
 #include <errno.h>
@@ skipping 786 matching lines @@
 
 size_t Tokenize(const base::StringPiece& str,
                 const base::StringPiece& delimiters,
                 std::vector<base::StringPiece>* tokens) {
   return TokenizeT(str, delimiters, tokens);
 }
 
 template<typename STR>
 static STR JoinStringT(const std::vector<STR>& parts,
                        typename STR::value_type sep) {
-  if (parts.size() == 0) return STR();
+  if (parts.empty()) return STR();

[Peter Kasting, 2011/03/02 00:02:42]

Nit: Style: return goes on separate line

 
   STR result(parts[0]);
   typename std::vector<STR>::const_iterator iter = parts.begin();

[Peter Kasting, 2011/03/02 00:02:42]

Nit: While here:

  STR result(parts[0]);
  for (std::vector<STR>::const_iterator i(parts.begin() + 1); i != parts.end();
       ++i)
    result += sep + *iter;
  return result;

   ++iter;
 
   for (; iter != parts.end(); ++iter) {
     result += sep;
     result += *iter;
   }
 
   return result;
 }
 
@@ skipping 266 matching lines @@
 }
 
 }  // namespace
 
 size_t base::strlcpy(char* dst, const char* src, size_t dst_size) {
   return lcpyT<char>(dst, src, dst_size);
 }
 size_t base::wcslcpy(wchar_t* dst, const wchar_t* src, size_t dst_size) {
   return lcpyT<wchar_t>(dst, src, dst_size);
 }