net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp

diff --git a/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp b/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp

index fcaff6062a6b0bc0935ef7fa73ff6d5729fca5c2..0cf9562ad327bbd39c25db1085842cb788f38cd2 100644

--- a/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp

+++ b/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp

@@ -277,7 +277,7 @@ int nsPKCS12Blob_Import(PK11SlotInfo* slot,

// zero length SECItem.

// We try both variations, zero length item and empty string,

// without giving a user prompt when trying the different empty password flavors.

- if (rv == net::ERR_PKCS12_IMPORT_BAD_PASSWORD && password.size() == 0) {

+ if (rv == net::ERR_PKCS12_IMPORT_BAD_PASSWORD && password.empty()) {

rv = nsPKCS12Blob_ImportHelper(pkcs12_data, pkcs12_len, password, true,

slot);

}