Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: net/base/dnssec_chain_verifier.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/dnssec_chain_verifier.cc
diff --git a/net/base/dnssec_chain_verifier.cc b/net/base/dnssec_chain_verifier.cc
index e6d31eef8db5cc9c1dd992a95d918d8049397200..6e6836549c2069fd51eadc78a3a2afffcbbbe9f3 100644
--- a/net/base/dnssec_chain_verifier.cc
+++ b/net/base/dnssec_chain_verifier.cc
@@ -489,7 +489,7 @@ bool DNSSECChainVerifier::ReadDNSKEYs(std::vector<base::StringPiece>* out,
base::StringPiece key;
if (!VariableLength16(&key))
return false;
- if (key.size() == 0) {
+ if (key.empty()) {
if (!is_root)
return false;
key = base::StringPiece(reinterpret_cast<const char*>(kRootKey),
@@ -597,7 +597,7 @@ DNSSECChainVerifier::Error DNSSECChainVerifier::EnterZone(
if (!ReadAheadKey(&key, entry_key))
return BAD_DATA;
- if (zone.size() == 1 && key.size() == 0) {
+ if (zone.size() == 1 && key.empty()) {
// If a key is omitted in the root zone then it's the root key.
key = base::StringPiece(reinterpret_cast<const char*>(kRootKey),
sizeof(kRootKey));
@@ -609,7 +609,7 @@ DNSSECChainVerifier::Error DNSSECChainVerifier::EnterZone(
if (!ReadDNSKEYs(&dnskeys, zone.size() == 1))
return BAD_DATA;
- if (sig.size() == 0) {
+ if (sig.empty()) {
// An omitted signature on the keys means that only the entry key is used.
if (dnskeys.size() > 1 || entry_key != 0)
return BAD_DATA;

Powered by Google App Engine
This is Rietveld 408576698