chrome/browser/extensions/extension_tabs_module.cc - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tabs_module.cc

diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc

index fd5c1373c2176c8c6f1d77ca817e54d2398b6b16..bb57b3c6dd5d904c82a970e580dc5cf815d8150c 100644

--- a/chrome/browser/extensions/extension_tabs_module.cc

+++ b/chrome/browser/extensions/extension_tabs_module.cc

@@ -478,7 +478,7 @@ bool CreateWindowFunction::RunImpl() {

TabStripModel* target_tab_strip = new_window->tabstrip_model();

target_tab_strip->InsertTabContentsAt(urls.size(), contents,

TabStripModel::ADD_NONE);

- } else if (urls.size() == 0) {

+ } else if (urls.empty()) {

new_window->NewTab();

}

new_window->SelectNumberedTab(0);