chrome/tools/convert_dict/dic_reader.cc - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/convert_dict/dic_reader.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/convert_dict/dic_reader.cc

diff --git a/chrome/tools/convert_dict/dic_reader.cc b/chrome/tools/convert_dict/dic_reader.cc

index 0475eff53c81df7614c1fdb46ab063d146e627fd..7b13abc39fedc2d501208bf4159eeeb2dd5e2dda 100644

--- a/chrome/tools/convert_dict/dic_reader.cc

+++ b/chrome/tools/convert_dict/dic_reader.cc

@@ -71,7 +71,7 @@ bool PopulateWordSet(WordSet* word_set, FILE* file, AffReader* aff_reader,

std::vector<std::string> split;

SplitDicLine(line, &split);

- if (split.size() == 0 || split.size() > 2) {

+ if (split.empty() || split.size() > 2) {

printf("Line %d has extra slashes in the %s file\n", line_number,

file_type);

return false;