Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: base/file_util_posix.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 6
7 #include <dirent.h> 7 #include <dirent.h>
8 #include <errno.h> 8 #include <errno.h>
9 #include <fcntl.h> 9 #include <fcntl.h>
10 #include <fnmatch.h> 10 #include <fnmatch.h>
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 : current_directory_entry_(0), 626 : current_directory_entry_(0),
627 root_path_(root_path), 627 root_path_(root_path),
628 recursive_(recursive), 628 recursive_(recursive),
629 file_type_(file_type), 629 file_type_(file_type),
630 pattern_(root_path.Append(pattern).value()) { 630 pattern_(root_path.Append(pattern).value()) {
631 // INCLUDE_DOT_DOT must not be specified if recursive. 631 // INCLUDE_DOT_DOT must not be specified if recursive.
632 DCHECK(!(recursive && (INCLUDE_DOT_DOT & file_type_))); 632 DCHECK(!(recursive && (INCLUDE_DOT_DOT & file_type_)));
633 // The Windows version of this code appends the pattern to the root_path, 633 // The Windows version of this code appends the pattern to the root_path,
634 // potentially only matching against items in the top-most directory. 634 // potentially only matching against items in the top-most directory.
635 // Do the same here. 635 // Do the same here.
636 if (pattern.size() == 0) 636 if (pattern.empty())
637 pattern_ = FilePath::StringType(); 637 pattern_ = FilePath::StringType();
638 pending_paths_.push(root_path); 638 pending_paths_.push(root_path);
639 } 639 }
640 640
641 FileEnumerator::~FileEnumerator() { 641 FileEnumerator::~FileEnumerator() {
642 } 642 }
643 643
644 FilePath FileEnumerator::Next() { 644 FilePath FileEnumerator::Next() {
645 ++current_directory_entry_; 645 ++current_directory_entry_;
646 646
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 if (HANDLE_EINTR(close(infile)) < 0) 881 if (HANDLE_EINTR(close(infile)) < 0)
882 result = false; 882 result = false;
883 if (HANDLE_EINTR(close(outfile)) < 0) 883 if (HANDLE_EINTR(close(outfile)) < 0)
884 result = false; 884 result = false;
885 885
886 return result; 886 return result;
887 } 887 }
888 #endif // defined(OS_MACOSX) 888 #endif // defined(OS_MACOSX)
889 889
890 } // namespace file_util 890 } // namespace file_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698