chrome/common/extensions/update_manifest.cc - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/update_manifest.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/update_manifest.cc

diff --git a/chrome/common/extensions/update_manifest.cc b/chrome/common/extensions/update_manifest.cc

index d2ceda7814348484b6ab0e70cb511c81ecc04665..4e1cdd54bcf9a8f405270114ef61fe201cf79f10 100644

--- a/chrome/common/extensions/update_manifest.cc

+++ b/chrome/common/extensions/update_manifest.cc

@@ -140,7 +140,7 @@ static bool ParseSingleAppTag(xmlNode* app_node, xmlNs* xml_namespace,

*error_detail = "Too many updatecheck tags on app (expecting only 1).";

return false;

}

- if (updates.size() == 0) {

+ if (updates.empty()) {

*error_detail = "Missing updatecheck on app.";

return false;

}