o3d/plugin/cross/stream_manager.cc - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: o3d/plugin/cross/stream_manager.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: o3d/plugin/cross/stream_manager.cc

diff --git a/o3d/plugin/cross/stream_manager.cc b/o3d/plugin/cross/stream_manager.cc

index 48da1c1c8a499e1a0746f9e4a644f19679ad6621..783b11461792cd6aed7d83cf7d010a68a1704fe4 100644

--- a/o3d/plugin/cross/stream_manager.cc

+++ b/o3d/plugin/cross/stream_manager.cc

@@ -310,7 +310,7 @@ bool StreamManager::NPDownloadStream::URLNotify(NPReason reason) {

// Note that the streaming case (NP_NORMAL) does not get a file

// so we can't check its size

if ((reason != NPRES_DONE) ||

- (stream_type_ != NP_NORMAL && file_.size() == 0)) {

+ (stream_type_ != NP_NORMAL && file_.empty())) {

// finished_callback should only be called once.

finished_callback_->Run(this, false, "", "");

finished_callback_.reset(NULL);