base/command_line_unittest.cc - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/command_line_unittest.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/command_line_unittest.cc

diff --git a/base/command_line_unittest.cc b/base/command_line_unittest.cc

index 6fd64407a470e1be897dec37d94cdad114d80b91..de8e4147b9055ae49675a6fc17dfb01c31ca05de 100644

--- a/base/command_line_unittest.cc

+++ b/base/command_line_unittest.cc

@@ -109,7 +109,7 @@ TEST(CommandLineTest, EmptyString) {

EXPECT_TRUE(cl.GetProgram().empty());

#elif defined(OS_POSIX)

CommandLine cl(0, NULL);

- EXPECT_TRUE(cl.argv().size() == 0);

+ EXPECT_EQ(0U, cl.argv().size());

Peter Kasting 2011/03/02 00:02:42 Nit: EXPECT_TRUE(cl.argv().empty()); (2 places)

#endif

EXPECT_EQ(0U, cl.args().size());

}

« no previous file with comments | « no previous file | base/crypto/encryptor_nss.cc » ('j') | base/file_path.cc » ('J')