Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1921)

Unified Diff: courgette/adjustment_method_2.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/adjustment_method_2.cc
diff --git a/courgette/adjustment_method_2.cc b/courgette/adjustment_method_2.cc
index e3ca31529f99bf6f1c5a5414040355913617663c..4a3d1c15beabe6ebe8a4da7c9e45c9a6cb60a88f 100644
--- a/courgette/adjustment_method_2.cc
+++ b/courgette/adjustment_method_2.cc
@@ -988,10 +988,10 @@ class AssignmentProblem {
if (single_use_score > 0) {
size_t n = single_use_pattern_queue_.erase(pattern);
LOG_ASSERT(n == 1);
- } else if (pattern->program_histogram_.size() == 0 &&
- pattern->model_histogram_.size() == 0) {
+ } else if (pattern->program_histogram_.empty() &&
+ pattern->model_histogram_.empty()) {
NOTREACHED(); // Should not come back to life.
- } else if (pattern->program_histogram_.size() == 0) {
+ } else if (pattern->program_histogram_.empty()) {
// Useless pattern.
} else {
active_non_single_use_patterns_.erase(pattern);
@@ -1003,9 +1003,9 @@ class AssignmentProblem {
int single_use_score = SingleUseScore(pattern);
if (single_use_score > 0) {
single_use_pattern_queue_.insert(pattern);
- } else if (pattern->program_histogram_.size() == 0 &&
- pattern->model_histogram_.size() == 0) {
- } else if (pattern->program_histogram_.size() == 0) {
+ } else if (pattern->program_histogram_.empty() &&
+ pattern->model_histogram_.empty()) {
+ } else if (pattern->program_histogram_.empty()) {
// Useless pattern.
} else {
active_non_single_use_patterns_.insert(pattern);

Powered by Google App Engine
This is Rietveld 408576698