o3d/core/cross/gpu2d/interval_tree_test.cc - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: o3d/core/cross/gpu2d/interval_tree_test.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: o3d/core/cross/gpu2d/interval_tree_test.cc

diff --git a/o3d/core/cross/gpu2d/interval_tree_test.cc b/o3d/core/cross/gpu2d/interval_tree_test.cc

index 29118b28e1f9353cf788794e225a2986d2f41a4c..95b48d00e82d21a7abb91a846a9f297edfc04867 100644

--- a/o3d/core/cross/gpu2d/interval_tree_test.cc

+++ b/o3d/core/cross/gpu2d/interval_tree_test.cc

@@ -177,9 +177,9 @@ InsertionAndDeletionTest(unsigned seed, int tree_size) {

// Now randomly add or remove elements.

for (int i = 0; i < 2 * tree_size; i++) {

bool add = false;

Peter Kasting 2011/03/02 00:02:42 Nit: Eliminate |add| and condense to: if (add

- if (added_elements.size() == 0) {

+ if (added_elements.empty()) {

add = true;

- } else if (removed_elements.size() == 0) {

+ } else if (removed_elements.empty()) {

add = false;

} else {

add = (NextRandom(2) == 1);