o3d/utils/cross/text_reader.cc - Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: o3d/utils/cross/text_reader.cc

Issue 6602049: Pure pedantry: Replace all ".size() == 0" with ".empty()". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: o3d/utils/cross/text_reader.cc

diff --git a/o3d/utils/cross/text_reader.cc b/o3d/utils/cross/text_reader.cc

index dccbffaabdd4b6612710aee53dc9d5d8efa08609..c6f1e5695e50e7d78dfb32babda4e50741fcb61e 100644

--- a/o3d/utils/cross/text_reader.cc

+++ b/o3d/utils/cross/text_reader.cc

@@ -48,7 +48,7 @@ TextReader::~TextReader() {

}

int TextReader::TestForEndOfLine(const std::string& eol) {

- if (eol.size() == 0) {

+ if (eol.empty()) {

Peter Kasting 2011/03/02 00:02:42 Nit: Eliminate anonymous namespace of consts and c

return 0;

}

if (eol[0] == kLinefeed) {