Pure pedantry: Replace all ".size() == 0" with ".empty()".

base/string_util.cc

Index: base/string_util.cc
diff --git a/base/string_util.cc b/base/string_util.cc
index ce12705b4ea07b260cda45088fb1eb34f9b35c4b..4af3ed9b062ff60951f75a0de5d5b93b2579b780 100644
--- a/base/string_util.cc
+++ b/base/string_util.cc
@@ -804,7 +804,7 @@ size_t Tokenize(const base::StringPiece& str,
 template<typename STR>
 static STR JoinStringT(const std::vector<STR>& parts,
                        typename STR::value_type sep) {
-  if (parts.size() == 0) return STR();
+  if (parts.empty()) return STR();

[Peter Kasting, 2011/03/02 00:02:42]

Nit: Style: return goes on separate line

 
   STR result(parts[0]);
   typename std::vector<STR>::const_iterator iter = parts.begin();

[Peter Kasting, 2011/03/02 00:02:42]

Nit: While here:

  STR result(parts[0]);
  for (std::vector<STR>::const_iterator i(parts.begin() + 1); i != parts.end();
       ++i)
    result += sep + *iter;
  return result;