Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2134006: Added EGL based GLContext.... (Closed)

Created:
10 years, 7 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam+cc_chromium.org, fbarchard, Alpha Left Google, John Grabowski, Paweł Hajdan Jr., apatrick_chromium, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Added EGL based GLContext. Python script to generate code to dynamically bind to GL functions (native GL, OSMesa, EGL or mock GL for unit tests). This replaces GLEW because GLEW doesn't bind to the GLES dialect of GL. Moved the mock GL code into app/gfx/gl. Updated the GPU code and AcceleratedSurface to use the new GL bindings. TEST=trybots BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49332

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 36

Patch Set 3 : '' #

Total comments: 12

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2020 lines, -2005 lines) Patch
M DEPS View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M app/app_base.gypi View 1 2 3 4 5 6 5 chunks +93 lines, -10 lines 0 comments Download
A app/gfx/gl/generate_bindings.py View 1 2 3 4 1 chunk +548 lines, -0 lines 0 comments Download
A app/gfx/gl/gl_bindings.h View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
M app/gfx/gl/gl_context.h View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M app/gfx/gl/gl_context.cc View 1 2 3 4 5 6 1 chunk +2 lines, -66 lines 0 comments Download
A app/gfx/gl/gl_context_egl.h View 1 1 chunk +93 lines, -0 lines 0 comments Download
A app/gfx/gl/gl_context_egl.cc View 1 1 chunk +241 lines, -0 lines 0 comments Download
M app/gfx/gl/gl_context_linux.cc View 1 2 3 4 5 6 15 chunks +60 lines, -99 lines 0 comments Download
M app/gfx/gl/gl_context_mac.cc View 1 2 3 4 5 6 6 chunks +28 lines, -26 lines 0 comments Download
M app/gfx/gl/gl_context_osmesa.h View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M app/gfx/gl/gl_context_osmesa.cc View 1 2 3 4 5 6 3 chunks +7 lines, -11 lines 0 comments Download
A app/gfx/gl/gl_context_stub.h View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
M app/gfx/gl/gl_context_win.cc View 1 2 3 4 5 6 12 chunks +184 lines, -141 lines 0 comments Download
A app/gfx/gl/gl_implementation.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A app/gfx/gl/gl_implementation_linux.cc View 1 2 3 4 5 6 1 chunk +80 lines, -0 lines 0 comments Download
A app/gfx/gl/gl_implementation_mac.cc View 1 2 3 4 5 6 1 chunk +76 lines, -0 lines 0 comments Download
A app/gfx/gl/gl_implementation_win.cc View 1 2 3 4 5 6 1 chunk +140 lines, -0 lines 0 comments Download
A + app/gfx/gl/gl_interface.h View 1 5 chunks +13 lines, -180 lines 0 comments Download
A + app/gfx/gl/gl_interface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + app/gfx/gl/gl_mock.h View 1 4 chunks +13 lines, -9 lines 0 comments Download
M app/surface/accelerated_surface_mac.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M chrome/gpu/gpu_backing_store_glx.cc View 1 2 3 4 5 6 4 chunks +34 lines, -28 lines 0 comments Download
M chrome/gpu/gpu_backing_store_glx_context.cc View 1 2 3 4 5 6 6 chunks +14 lines, -17 lines 0 comments Download
M chrome/gpu/gpu_main.cc View 1 2 3 4 5 6 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/gpu/gpu_video_layer_glx.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/gpu/gpu_view_x.cc View 1 2 3 4 5 6 4 chunks +15 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 2 3 4 5 6 2 chunks +24 lines, -19 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
A gpu/command_buffer/common/unittest_main.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
D gpu/command_buffer/service/gl_context_stub.cc View 1 2 3 4 5 6 1 chunk +0 lines, -44 lines 0 comments Download
D gpu/command_buffer/service/gl_interface.h View 1 2 3 4 5 6 1 chunk +0 lines, -563 lines 0 comments Download
D gpu/command_buffer/service/gl_interface.cc View 1 2 3 4 5 6 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/command_buffer/service/gl_mock.h View 1 2 3 4 5 6 1 chunk +0 lines, -389 lines 0 comments Download
D gpu/command_buffer/service/gl_mock.cc View 1 2 3 4 5 6 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 2 3 4 5 6 1 chunk +18 lines, -75 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 22 chunks +95 lines, -69 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor.h View 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_linux.cc View 2 3 4 5 6 2 chunks +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_mac.cc View 2 3 4 5 6 4 chunks +1 line, -21 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_win.cc View 1 2 3 4 5 6 1 chunk +2 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 2 3 4 5 6 3 chunks +6 lines, -5 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 6 6 chunks +39 lines, -130 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/gles2_book/Chapter_8/Simple_VertexShader/Simple_VertexShader.c View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
apatrick_chromium
This is going to need some more work. In particular, mac will not work yet. ...
10 years, 6 months ago (2010-06-02 23:45:42 UTC) #1
greggman
Looking good. Please don't make me read it again :-p A few random comments. Would ...
10 years, 6 months ago (2010-06-03 01:45:05 UTC) #2
scherkus (not reviewing)
I only looked at the chrome/gpu/* stuff don't worry about breaking that stuff.. brettw/myself were ...
10 years, 6 months ago (2010-06-03 22:14:45 UTC) #3
apatrick_chromium
Getting there... http://codereview.chromium.org/2134006/diff/42001/43003 File app/gfx/gl/generate_bindings.py (right): http://codereview.chromium.org/2134006/diff/42001/43003#newcode321 app/gfx/gl/generate_bindings.py:321: ['XVisualInfo*', ['glXChooseVisual'], 'Display* dpy, int screen, int* ...
10 years, 6 months ago (2010-06-04 22:41:10 UTC) #4
Ken Russell (switch to Gerrit)
Having trouble viewing a lot of the diffs in this version. Errors are of the ...
10 years, 6 months ago (2010-06-05 00:50:47 UTC) #5
greggman
LGTM http://codereview.chromium.org/2134006/diff/42001/43004 File app/gfx/gl/gl_bindings.h (right): http://codereview.chromium.org/2134006/diff/42001/43004#newcode73 app/gfx/gl/gl_bindings.h:73: void* GL_BINDING_CALL GetMockGLProcAddress(const char* name); On 2010/06/04 22:41:11, ...
10 years, 6 months ago (2010-06-07 19:11:46 UTC) #6
apatrick_chromium
I uploaded again. I find the the "Delta from patch set" links do not work ...
10 years, 6 months ago (2010-06-07 19:34:39 UTC) #7
Ken Russell (switch to Gerrit)
LGTM The elimination of the UNIT_TEST #define is great. I've been bitten by its presence ...
10 years, 6 months ago (2010-06-09 00:01:14 UTC) #8
apatrick_chromium
http://codereview.chromium.org/2134006/diff/89001/90003 File app/gfx/gl/generate_bindings.py (right): http://codereview.chromium.org/2134006/diff/89001/90003#newcode413 app/gfx/gl/generate_bindings.py:413: # Write prototype for initilization function. On 2010/06/05 00:50:48, ...
10 years, 6 months ago (2010-06-09 01:06:43 UTC) #9
apatrick
My mac try job came so close to compiling :( I have run the gpu ...
10 years, 6 months ago (2010-06-09 02:50:21 UTC) #10
apatrick_chromium
10 years, 6 months ago (2010-06-09 23:17:39 UTC) #11
scherkus, this code landed with r49332 and your immediate mode GL code is now
commented out.

Powered by Google App Engine
This is Rietveld 408576698