Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 827973002: ViewMatrix uniform upload moved to GeometryProcessor (Closed)

Created:
5 years, 11 months ago by joshua.litt
Modified:
5 years, 11 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vm-on-gp
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

ViewMatrix uniform upload moved to GeometryProcessor BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee2af95db72152dfa61c841875df0594ca93437d

Patch Set 1 #

Patch Set 2 : more cleanup #

Total comments: 3

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -112 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrGeometryProcessor.cpp View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 2 chunks +0 lines, -13 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 6 chunks +18 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 6 chunks +21 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 4 chunks +12 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 6 chunks +19 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 1 chunk +33 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 chunks +9 lines, -37 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 3 chunks +13 lines, -20 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
In this CL I remove the VM from optstate and let the GeoProc / PathProc ...
5 years, 11 months ago (2014-12-29 19:14:19 UTC) #3
bsalomon
lgtm w/ some requests for comment/name updates. https://codereview.chromium.org/827973002/diff/20001/src/gpu/GrGeometryProcessor.cpp File src/gpu/GrGeometryProcessor.cpp (right): https://codereview.chromium.org/827973002/diff/20001/src/gpu/GrGeometryProcessor.cpp#newcode59 src/gpu/GrGeometryProcessor.cpp:59: void GrGLGeometryProcessor::setupUniformViewMatrix(GrGLGPBuilder* ...
5 years, 11 months ago (2014-12-30 13:19:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827973002/40001
5 years, 11 months ago (2014-12-30 16:54:25 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2014-12-30 17:04:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ee2af95db72152dfa61c841875df0594ca93437d

Powered by Google App Engine
This is Rietveld 408576698