src/gpu/gl/builders/GrGLProgramBuilder.cpp - Issue 827973002: ViewMatrix uniform upload moved to GeometryProcessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/builders/GrGLProgramBuilder.cpp

Issue 827973002: ViewMatrix uniform upload moved to GeometryProcessor (Closed) Base URL: https://skia.googlesource.com/skia.git@vm-on-gp

Patch Set: feedback inc Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/builders/GrGLProgramBuilder.cpp

diff --git a/src/gpu/gl/builders/GrGLProgramBuilder.cpp b/src/gpu/gl/builders/GrGLProgramBuilder.cpp

index c414aba9ff3603d559de9521293998cbd1c2e9f0..0c4178197913d1c741a33713bac2f335a4e10130 100644

--- a/src/gpu/gl/builders/GrGLProgramBuilder.cpp

+++ b/src/gpu/gl/builders/GrGLProgramBuilder.cpp

@@ -178,8 +178,6 @@ const GrGLContextInfo& GrGLProgramBuilder::ctxInfo() const {

void GrGLProgramBuilder::emitAndInstallProcs(GrGLSLExpr4* inputColor, GrGLSLExpr4* inputCoverage) {

if (fOptState.hasGeometryProcessor()) {

- fVS.setupUniformViewMatrix();

fVS.codeAppend("gl_PointSize = 1.0;");

// Setup position