Rework the way Widget::Init works:

Rework the way Widget::Init works:
- Remove SetCreateParams from the public Widget API.
- Add parent/bounds fields to CreateParams
- Make Widget::Init be the canonical init method (vs. WidgetWin/Gtk Init) and have it take a CreateParams.
- NativeWidget now has a InitNativeWidget method, which subclasses can override. Everyone must call Widget::Init via Widget* (not WidgetWin* as this will be ambiguous to WindowImpl::Init).

BUG=72040
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83037

[sky, 2011-04-25 23:49:32]

LGTM

http://codereview.chromium.org/6881107/diff/15001/views/widget/widget.h
File views/widget/widget.h (right):

http://codereview.chromium.org/6881107/diff/15001/views/widget/widget.h#newco...
views/widget/widget.h:65: struct CreateParams {
Consider renaming this to InitParams.

http://codereview.chromium.org/6881107/diff/15001/views/widget/widget_gtk.cc
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/6881107/diff/15001/views/widget/widget_gtk.cc#...
views/widget/widget_gtk.cc:291: child_(false),
Should be after transparent_

http://codereview.chromium.org/6881107/diff/15001/views/widget/widget_gtk.cc#...
views/widget/widget_gtk.cc:1397: event->type == GDK_2BUTTON_PRESS ||
indent 4 (and next line).

[Ben Goodger (Google), 2011-04-26 14:42:56]

On 2011/04/25 23:49:32, sky wrote:
http://codereview.chromium.org/6881107/diff/15001/views/widget/widget.h#newco...
> views/widget/widget.h:65: struct CreateParams {
> Consider renaming this to InitParams.

I am going to do this in a separate CL, adding a TODO for now.

http://codereview.chromium.org/6881107/diff/15001/views/widget/widget_gtk.cc#...
> views/widget/widget_gtk.cc:291: child_(false),
> Should be after transparent_

??? It matches the order in the class decl. I grouped it with the parent widget
members since it seemed related to widget hierarchy.