Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: chrome/browser/ui/views/browser_bubble_gtk.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_bubble_gtk.cc
===================================================================
--- chrome/browser/ui/views/browser_bubble_gtk.cc (revision 83020)
+++ chrome/browser/ui/views/browser_bubble_gtk.cc (working copy)
@@ -23,8 +23,7 @@
class BubbleWidget : public views::WidgetGtk {
public:
explicit BubbleWidget(BrowserBubble* bubble)
- : views::WidgetGtk(views::WidgetGtk::TYPE_WINDOW),
- bubble_(bubble),
+ : bubble_(bubble),
border_contents_(new BorderContents) {
border_contents_->Init();
}
@@ -95,7 +94,9 @@
BubbleWidget* pop = new BubbleWidget(this);
pop->MakeTransparent();
pop->make_transient_to_parent();
- pop->Init(frame_->GetNativeView(), gfx::Rect());
+ views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_WINDOW);
+ params.parent = frame_->GetNativeView();
+ pop->Init(params);
#if defined(OS_CHROMEOS)
{
vector<int> params;
« no previous file with comments | « chrome/browser/ui/views/autocomplete/autocomplete_popup_gtk.cc ('k') | chrome/browser/ui/views/browser_bubble_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698