chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc - Issue 6881107: Rework the way Widget::Init works:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc

===================================================================

--- chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc (revision 83020)

+++ chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc (working copy)

@@ -332,8 +332,9 @@

views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_POPUP);

params.can_activate = false;

params.transparent = true;

- popup_->SetCreateParams(params);

- popup_->Init(location_bar_->GetWidget()->GetNativeView(), GetPopupBounds());

+ params.parent = location_bar_->GetWidget()->GetNativeView();

+ params.bounds = GetPopupBounds();

+ popup_->GetWidget()->Init(params);

popup_->SetContentsView(this);

popup_->MoveAbove(popup_->GetRelativeWindowForPopup(

edit_view_->GetNativeView()));