Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/browser/ui/views/browser_bubble_win.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/browser_bubble_gtk.cc ('k') | chrome/browser/ui/views/bubble/border_widget_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/browser_bubble_win.cc
===================================================================
--- chrome/browser/ui/views/browser_bubble_win.cc (revision 83020)
+++ chrome/browser/ui/views/browser_bubble_win.cc (working copy)
@@ -109,16 +109,19 @@
// popup_ is a Widget, but we need to do some WidgetWin stuff first, then
// we'll assign it into popup_.
BubbleWidget* pop = new BubbleWidget(this);
+ popup_ = pop;
BorderWidgetWin* border_widget = pop->border_widget();
- border_widget->Init(new BorderContents, frame_->GetNativeView());
+ border_widget->InitBorderWidgetWin(new BorderContents,
+ frame_->GetNativeView());
// We make the BorderWidgetWin the owner of the Bubble HWND, so that the
// latter is displayed on top of the former.
- pop->Init(border_widget->GetNativeView(), gfx::Rect());
- pop->SetContentsView(view_);
+ views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_POPUP);
+ params.parent = border_widget->GetNativeView();
+ popup_->Init(params);
+ popup_->SetContentsView(view_);
- popup_ = pop;
ResizeToView();
Reposition();
« no previous file with comments | « chrome/browser/ui/views/browser_bubble_gtk.cc ('k') | chrome/browser/ui/views/bubble/border_widget_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698