Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: chrome/browser/chromeos/notifications/balloon_view.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/notifications/balloon_view.cc
===================================================================
--- chrome/browser/chromeos/notifications/balloon_view.cc (revision 83020)
+++ chrome/browser/chromeos/notifications/balloon_view.cc (working copy)
@@ -267,19 +267,19 @@
void BalloonViewImpl::ViewHierarchyChanged(
bool is_add, View* parent, View* child) {
if (is_add && GetWidget() && !control_view_host_.get() && controls_) {
+ control_view_host_.reset(views::Widget::CreateWidget());
+ static_cast<views::WidgetGtk*>(control_view_host_.get())->
+ EnableDoubleBuffer(true);
views::Widget::CreateParams params(
views::Widget::CreateParams::TYPE_CONTROL);
params.delete_on_destroy = false;
- control_view_host_.reset(views::Widget::CreateWidget(params));
- static_cast<views::WidgetGtk*>(control_view_host_.get())->
- EnableDoubleBuffer(true);
- control_view_host_->Init(GetParentNativeView(), gfx::Rect());
+ params.parent = GetParentNativeView();
+ control_view_host_->Init(params);
NotificationControlView* control = new NotificationControlView(this);
control_view_host_->SetContentsView(control);
}
- if (!is_add && this == child && control_view_host_.get() && controls_) {
+ if (!is_add && this == child && control_view_host_.get() && controls_)
control_view_host_.release()->CloseNow();
- }
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | chrome/browser/chromeos/notifications/notification_panel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698