views/window/window_gtk.cc - Issue 6881107: Rework the way Widget::Init works:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/window/window_gtk.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/window/window_gtk.cc

===================================================================

--- views/window/window_gtk.cc (revision 83020)

+++ views/window/window_gtk.cc (working copy)

@@ -408,8 +408,7 @@

// WindowGtk, protected:

WindowGtk::WindowGtk(WindowDelegate* window_delegate)

- : WidgetGtk(TYPE_WINDOW),

- Window(window_delegate),

+ : Window(window_delegate),

ALLOW_THIS_IN_INITIALIZER_LIST(delegate_(this)),

window_state_(GDK_WINDOW_STATE_WITHDRAWN),

window_closed_(false) {

@@ -420,7 +419,10 @@

void WindowGtk::InitWindow(GtkWindow* parent, const gfx::Rect& bounds) {

if (parent)

make_transient_to_parent();

- WidgetGtk::Init(GTK_WIDGET(parent), bounds);

+ Widget::CreateParams params(Widget::CreateParams::TYPE_WINDOW);

+ params.parent = GTK_WIDGET(parent);

+ params.bounds = bounds;

+ GetWidget()->Init(params);

delegate_->OnNativeWindowCreated(bounds);

g_signal_connect(G_OBJECT(GetNativeWindow()), "configure-event",

« no previous file with comments | « views/widget/widget_win_unittest.cc ('k') | views/window/window_win.h » ('j') | no next file with comments »