Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2770)

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/first_run/try_chrome_dialog_view.cc
===================================================================
--- chrome/browser/first_run/try_chrome_dialog_view.cc (revision 83020)
+++ chrome/browser/first_run/try_chrome_dialog_view.cc (working copy)
@@ -65,16 +65,16 @@
gfx::Size icon_size = icon->GetPreferredSize();
// An approximate window size. After Layout() we'll get better bounds.
- views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_POPUP);
- params.can_activate = true;
- popup_ = views::Widget::CreateWidget(params);
+ popup_ = views::Widget::CreateWidget();
if (!popup_) {
NOTREACHED();
return DIALOG_ERROR;
}
- gfx::Rect pos(310, 160);
- popup_->Init(NULL, pos);
+ views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_POPUP);
+ params.can_activate = true;
+ params.bounds = gfx::Rect(310, 160);
+ popup_->Init(params);
views::RootView* root_view = popup_->GetRootView();
// The window color is a tiny bit off-white.
@@ -194,8 +194,8 @@
// account the differences between XP and Vista fonts and buttons.
layout->Layout(root_view);
gfx::Size preferred = layout->GetPreferredSize(root_view);
- pos = ComputeWindowPosition(preferred.width(), preferred.height(),
- base::i18n::IsRTL());
+ gfx::Rect pos = ComputeWindowPosition(preferred.width(), preferred.height(),
+ base::i18n::IsRTL());
popup_->SetBounds(pos);
// Carve the toast shape into the window.
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698