Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: chrome/browser/chromeos/login/wizard_controller.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller.cc
===================================================================
--- chrome/browser/chromeos/login/wizard_controller.cc (revision 83020)
+++ chrome/browser/chromeos/login/wizard_controller.cc (working copy)
@@ -596,18 +596,19 @@
views::Widget* WizardController::CreateScreenWindow(
const gfx::Rect& bounds, bool initial_show) {
- views::Widget::CreateParams widget_params(
- views::Widget::CreateParams::TYPE_WINDOW);
- widget_params.transparent = true;
- widget_ = views::Widget::CreateWidget(widget_params);
+ widget_ = views::Widget::CreateWidget();
// Window transparency makes background flicker through controls that
// are constantly updating its contents (like image view with video
// stream). Hence enabling double buffer.
static_cast<views::WidgetGtk*>(widget_)->EnableDoubleBuffer(true);
- widget_->Init(NULL, bounds);
+ views::Widget::CreateParams widget_params(
+ views::Widget::CreateParams::TYPE_WINDOW);
+ widget_params.transparent = true;
+ widget_params.bounds = bounds;
+ widget_->Init(widget_params);
std::vector<int> params;
// For initial show WM would animate background window.
- // Otherwise it stays unchaged.
+ // Otherwise it stays unchanged.
params.push_back(initial_show);
chromeos::WmIpc::instance()->SetWindowType(
widget_->GetNativeView(),
« no previous file with comments | « chrome/browser/chromeos/login/user_controller_gtk.cc ('k') | chrome/browser/chromeos/notifications/balloon_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698