Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4981)

Unified Diff: chrome/browser/ui/views/native_constrained_window_win.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/native_constrained_window_win.cc
===================================================================
--- chrome/browser/ui/views/native_constrained_window_win.cc (revision 83020)
+++ chrome/browser/ui/views/native_constrained_window_win.cc (working copy)
@@ -19,10 +19,6 @@
views::WindowDelegate* window_delegate)
: WindowWin(window_delegate),
delegate_(delegate) {
- views::Widget::CreateParams params(
- views::Widget::CreateParams::TYPE_WINDOW);
- params.child = true;
- SetCreateParams(params);
}
virtual ~NativeConstrainedWindowWin() {
@@ -31,7 +27,11 @@
private:
// Overridden from NativeConstrainedWindow:
virtual void InitNativeConstrainedWindow(gfx::NativeView parent) OVERRIDE {
- WindowWin::Init(parent, gfx::Rect());
+ views::Widget::CreateParams params(
+ views::Widget::CreateParams::TYPE_WINDOW);
+ params.child = true;
+ params.parent = parent;
+ GetWidget()->Init(params);
}
virtual views::NativeWindow* AsNativeWindow() OVERRIDE {
return this;
« no previous file with comments | « chrome/browser/ui/views/generic_info_view_unittest.cc ('k') | chrome/browser/ui/views/notifications/balloon_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698